Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI workflow to 2024 images. #1745

Merged
merged 1 commit into from
May 8, 2024

Conversation

xlietz
Copy link
Contributor

@xlietz xlietz commented May 6, 2024

Updated CI workflow to 2024 docker images.

@xlietz xlietz requested review from cary-ilm and kdt3rd May 6, 2024 21:53
Copy link
Contributor

@kdt3rd kdt3rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the 2020 year and just keep the past 3 years? Either way to me, but looks fine otherwise, thanks for keeping on this!

@cary-ilm
Copy link
Member

cary-ilm commented May 7, 2024

@xlietz, I agree with Kimball, let's keep just the past 3 years, so drop 2020. Thanks!

@xlietz
Copy link
Contributor Author

xlietz commented May 8, 2024

Thanks for reviewing! I had kept 2020 since it was C++14 but I just realized I already have a C++14 build in the latest images section. I'll remove it!

Signed-off-by: Christina Tempelaar-Lietz <xlietz@gmail.com>
@xlietz xlietz merged commit 810e456 into AcademySoftwareFoundation:main May 8, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants